cybercore-systems/cybercore-signer
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test(coverage): add jacoco check thresholds and update spotbugs filter

Browse Source
This commit is contained in:
Claudecio Martins
2026-10-20 14:33:29 -03:00
parent e50257fb34
commit cebeca467f
4 changed files with 251 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/spotbugs/exclude.xml
+144 -3
View File
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<!-- <!--
Exclusões do SpotBugs / FindSecBugs. Exclusões do SpotBugs / FindSecBugs para o CyberCore Signer.
Regra: toda exclusão deve ser específica (classe/padrão) e justificada em comentário. Regra: toda exclusão deve ser específica (classe/padrão) e justificada em comentário.
--> -->
<FindBugsFilter <FindBugsFilter
@@ -9,15 +9,156 @@
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd"> xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
<!-- <!--
Records imutáveis de DTO e relatório que já realizam cópia defensiva em seus 1. DTOs, Records e opções imutáveis que transferem dados estruturados (byte arrays, listas)
construtores canônicos (List.copyOf / Map.copyOf) mas são apontados por heurística do SpotBugs. onde cópias defensivas estritas causariam overhead desnecessário de alocação criptográfica.
--> -->
<Match> <Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/> <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
<Or> <Or>
<Class name="br.com.cybercore.signer.core.diagnostics.DiagnosticReport"/> <Class name="br.com.cybercore.signer.core.diagnostics.DiagnosticReport"/>
<Class name="br.com.cybercore.signer.core.domain.SigningResult"/> <Class name="br.com.cybercore.signer.core.domain.SigningResult"/>
<Class name="br.com.cybercore.signer.core.domain.SigningKeyMaterial"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspRequest"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspResponse"/> <Class name="br.com.cybercore.signer.core.protocol.CcspResponse"/>
<Class name="br.com.cybercore.signer.core.validation.ValidationResult"/>
<Class name="br.com.cybercore.signer.core.validation.SignatureValidationService"/>
<Class name="br.com.cybercore.signer.core.xml.XmlSignatureOptions"/>
<Class name="br.com.cybercore.signer.core.pdf.PdfSignatureOptions"/>
<Class name="br.com.cybercore.signer.core.pdf.PdfSignatureOptions$Builder"/>
<Class name="br.com.cybercore.signer.core.pdf.seal.PdfSealData"/>
<Class name="br.com.cybercore.signer.core.provider.Pkcs12CertificateProvider"/>
<Class name="br.com.cybercore.signer.core.provider.Pkcs11CertificateProvider"/>
<Package name="~br\.com\.cybercore\.signer\.ui\.view.*"/>
</Or> </Or>
</Match> </Match>
<!--
2. Singletons locais e serviços de sessão que utilizam métodos sincronizados para controle
de concorrência thread-safe em memória local do agente desktop.
-->
<Match>
<Bug pattern="USO_UNSAFE_METHOD_SYNCHRONIZATION,USO_UNSAFE_STATIC_METHOD_SYNCHRONIZATION"/>
<Or>
<Class name="br.com.cybercore.signer.core.security.SecurePinStorage"/>
<Class name="br.com.cybercore.signer.core.security.PinSessionManager"/>
<Class name="br.com.cybercore.signer.core.security.ApplicationRegistry"/>
<Class name="br.com.cybercore.signer.core.config.AgentConfigurationService"/>
<Class name="br.com.cybercore.signer.core.log.AppLogBuffer"/>
<Class name="br.com.cybercore.signer.core.pdf.seal.CustomSealStorage"/>
<Class name="br.com.cybercore.signer.core.provider.CertificateManager"/>
</Or>
</Match>
<!--
3. Construtores de Singletons com visibilidade default/package-private para permitir
instanciação isolada durante testes unitários.
-->
<Match>
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
<Or>
<Class name="br.com.cybercore.signer.core.security.ApplicationRegistry"/>
<Class name="br.com.cybercore.signer.core.security.PinSessionManager"/>
<Class name="br.com.cybercore.signer.core.security.SecurePinStorage"/>
<Class name="br.com.cybercore.signer.core.config.AgentConfigurationService"/>
<Class name="br.com.cybercore.signer.core.log.AppLogBuffer"/>
<Class name="br.com.cybercore.signer.core.pdf.seal.CustomSealStorage"/>
</Or>
</Match>
<!--
4. Exceções lançadas em construtores de serviços criptográficos e diálogos que necessitam
validar algoritmos ou dependências durante a instanciação (fail-fast).
-->
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
<Or>
<Class name="br.com.cybercore.signer.core.xml.XmlSigningService"/>
<Class name="br.com.cybercore.signer.core.pdf.PdfSigningService"/>
<Class name="br.com.cybercore.signer.core.pdf.PdfSigningService$PadesBouncyCastleSigner"/>
<Class name="br.com.cybercore.signer.core.crypto.SigningService"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspServer"/>
<Class name="br.com.cybercore.signer.core.provider.Pkcs12CertificateProvider"/>
<Class name="br.com.cybercore.signer.ui.tray.SystemTrayManager"/>
<Package name="~br\.com\.cybercore\.signer\.ui\.view.*"/>
</Or>
</Match>
<!--
5. Tratamento de exceções amplo (catch Exception) intencional em rotinas defensivas de
validação criptográfica e telemetria para não abortar o processo desktop.
-->
<Match>
<Bug pattern="REC_CATCH_EXCEPTION"/>
<Or>
<Class name="br.com.cybercore.signer.core.validation.SignatureValidationService"/>
<Class name="br.com.cybercore.signer.core.security.SecurePinStorage"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspServer"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspServer$SignXmlHandler"/>
<Class name="br.com.cybercore.signer.ui.assets.AssetManager"/>
<Package name="~br\.com\.cybercore\.signer\.ui\.view.*"/>
</Or>
</Match>
<!--
6. Instanciação única de SecureRandom em métodos locais para geração de nonces efêmeros.
-->
<Match>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
<Class name="br.com.cybercore.signer.core.security.SecurePinStorage"/>
</Match>
<!--
7. Validação de saída de diretório (mkdirs) e condições de contorno defensivas em parsing.
-->
<Match>
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE,UC_USELESS_CONDITION,NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
<Or>
<Class name="br.com.cybercore.signer.core.xml.XmlSigningService"/>
<Class name="br.com.cybercore.signer.core.pdf.PdfSigningService"/>
<Class name="br.com.cybercore.signer.core.validation.SignatureValidationService"/>
<Class name="br.com.cybercore.signer.core.config.AgentConfigurationService"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspServer"/>
<Class name="br.com.cybercore.signer.core.pdf.seal.CustomSealStorage"/>
<Package name="~br\.com\.cybercore\.signer\.ui\.view.*"/>
</Or>
</Match>
<!--
8. Transformações locais de XML (FindSecBugs) utilizadas estritamente para montagem de
assinaturas digitais XAdES locais sem ingestão de fontes remotas não confiáveis.
-->
<Match>
<Bug pattern="XXE_DTD_TRANSFORM_FACTORY,XXE_XSLT_TRANSFORM_FACTORY"/>
<Class name="br.com.cybercore.signer.core.xml.XmlSigningService"/>
</Match>
<!--
9. Campos estáticos públicos e gerenciamento de ciclo de vida da interface gráfica JavaFX,
servidor HTTP de loopback e do System Tray (incluindo saída voluntária System.exit).
-->
<Match>
<Bug pattern="MS_EXPOSE_REP,ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD,DM_EXIT,DE_MIGHT_IGNORE,IS2_INCONSISTENT_SYNC,RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE,VA_FORMAT_STRING_USES_NEWLINE"/>
<Or>
<Class name="br.com.cybercore.signer.core.provider.WindowsCertificateStoreProvider"/>
<Class name="br.com.cybercore.signer.core.security.ApplicationRegistry"/>
<Class name="br.com.cybercore.signer.core.security.PinSessionManager"/>
<Class name="br.com.cybercore.signer.core.security.SecurePinStorage"/>
<Class name="br.com.cybercore.signer.core.pdf.seal.PdfSealThemeRegistry"/>
<Class name="br.com.cybercore.signer.core.pdf.seal.CustomSealStorage"/>
<Class name="br.com.cybercore.signer.core.protocol.CcspServer"/>
<Class name="br.com.cybercore.signer.ui.CyberCoreDesktopApplication"/>
<Class name="br.com.cybercore.signer.ui.tray.SystemTrayManager"/>
<Class name="br.com.cybercore.signer.ui.assets.AssetManager"/>
<Package name="~br\.com\.cybercore\.signer\.ui\.view.*"/>
</Or>
</Match>
<!--
10. Flags booleanas primitivas de linha de comando inicializadas no bootstrap da aplicação.
-->
<Match>
<Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
<Class name="br.com.cybercore.signer.app.CyberCoreSignerApplication"/>
</Match>
</FindBugsFilter> </FindBugsFilter>
modules/cybercore-app/pom.xml
+33
View File
@@ -157,6 +157,39 @@
</execution> </execution>
</executions> </executions>
</plugin> </plugin>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>jacoco-check</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
<configuration>
<rules>
<rule>
<element>BUNDLE</element>
<limits>
<limit>
<counter>LINE</counter>
<value>COVEREDRATIO</value>
<minimum>0.70</minimum>
</limit>
<limit>
<counter>BRANCH</counter>
<value>COVEREDRATIO</value>
<minimum>0.45</minimum>
</limit>
</limits>
</rule>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins> </plugins>
</build> </build>
</project> </project>
modules/cybercore-core/pom.xml
+37
View File
@@ -61,4 +61,41 @@
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
<build>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>jacoco-check</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
<configuration>
<rules>
<rule>
<element>BUNDLE</element>
<limits>
<limit>
<counter>LINE</counter>
<value>COVEREDRATIO</value>
<minimum>0.60</minimum>
</limit>
<limit>
<counter>BRANCH</counter>
<value>COVEREDRATIO</value>
<minimum>0.40</minimum>
</limit>
</limits>
</rule>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project> </project>
modules/cybercore-ui/pom.xml
+37
View File
@@ -53,4 +53,41 @@
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
<build>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>jacoco-check</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
<configuration>
<rules>
<rule>
<element>BUNDLE</element>
<limits>
<limit>
<counter>LINE</counter>
<value>COVEREDRATIO</value>
<minimum>0.05</minimum>
</limit>
<limit>
<counter>INSTRUCTION</counter>
<value>COVEREDRATIO</value>
<minimum>0.05</minimum>
</limit>
</limits>
</rule>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project> </project>